Open
Conversation
silesmo
force-pushed
the
dev/timmy/csharp-macos-support
branch
3 times, most recently
from
facead9 to
0df3a74
Compare
silesmo
force-pushed
the
dev/timmy/csharp-macos-support
branch
from
0df3a74 to
7373933
Compare
yowl
reviewed
Apr 3, 2026
Collaborator
yowl
left a comment
yowl
left a comment
There was a problem hiding this comment.
Just curious about fixing the commit.
| lang: csharp | ||
| runs-on: ${{ matrix.os }} | ||
| env: | ||
| RUNTIMELAB_COMMIT: '4cac3ab5c8e97fda69c23dfca41ace964babc05e' |
| ./build.sh libs -c Release /p:NuGetAudit=false | ||
| LLVM_CMAKE_CONFIG_RELEASE=$(brew --prefix llvm@18)/lib/cmake/llvm \ | ||
| src/coreclr/build-runtime.sh -arm64 -release -os osx -outputrid osx-arm64 -component llvmjit | ||
| cp artifacts/bin/coreclr/osx.arm64.Release/libclrjit_universal_llvm32_arm64.dylib artifacts/bin/coreclr/osx.arm64.Release/ilc-published/ |
Collaborator
There was a problem hiding this comment.
Interesting, something must be missing in the runtimelab build to make this necessary. Not saying anything needs changing, just if we want to push this to runtimelab, we will have to make the build copy these files.
| <PackageReference Include="Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" /> | ||
| <PackageReference Include="runtime.{os}-x64.Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" /> | ||
| <PackageReference Include="Microsoft.DotNet.ILCompiler.LLVM" Version="{ilc_version}" /> | ||
| <PackageReference Include="runtime.{os}-{arch}.Microsoft.DotNet.ILCompiler.LLVM" Version="{ilc_version}" /> |
Collaborator
There was a problem hiding this comment.
This might be a problem for arm64 on windows as we don't have that either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build and test it ourselves since it's not a published package based on: dotnet/runtimelab#2119